Report min finalized head for traceless datasets NET-888#128
Open
kalabukdima wants to merge 1 commit into
Open
Report min finalized head for traceless datasets NET-888#128kalabukdima wants to merge 1 commit into
kalabukdima wants to merge 1 commit into
Conversation
The traced and traceless hotblocks variants finalize independently, so advertising only the traced head let a traceless stream head-wait and 204 when it hadn't finalized that far yet. Report the minimum of both heads. Part of NET-888
Contributor
|
What are finalization bugs in RPCs? This change may affect Squid SDK |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Normally, traceless dataset variants should be ahead of traceful ones. But due to finalization bugs in RPCs, sometimes they're the other way.
Returning the minimum of the two heads to fix the invariant: "once a block is returned by
/finalized-head, it should be available at/finalized-streamon that portal". It's important for the RPC proxy's correctness.